Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated copyright notices #1477

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

davidlago
Copy link

Signed-off-by: Dave Lago davelago@amazon.com

opensearch-security pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly

  1. Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance

  1. Github Issue # or road-map entry, if available:

#1395

  1. Description of changes:

Updated copyright notices to say OpenSearch Contributors

  1. Why these changes are required?

Licensing concerns

  1. What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)

No behavior change

  1. Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)

N/A

  1. TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

N/A

  1. Is it backport from main branch? (If yes, please add backport PR # and commits #)

No

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@davidlago davidlago requested a review from a team October 28, 2021 14:17
@@ -16,7 +16,7 @@
*/
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still unclear what to do about the first notice above mentioning floragunn ^

@davidlago
Copy link
Author

davidlago commented Oct 28, 2021

My overall concern is the fact that for a big portion of our files, the copyright notice header has two parts. One for floragunn, and a second one that says that parts of the code are copyright opensearch contributors (see src/main/java/org/opensearch/security/action/whoami/WhoAmIResponse.java for example).

@davidlago
Copy link
Author

Build will pass once we downmerge PR #1479

Signed-off-by: Dave Lago <davelago@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1477 (36aaa4e) into main (42b118b) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 36aaa4e differs from pull request most recent head e50cade. Consider uploading reports for the commit e50cade to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1477      +/-   ##
============================================
+ Coverage     64.84%   64.86%   +0.01%     
  Complexity     3228     3228              
============================================
  Files           247      247              
  Lines         17335    17335              
  Branches       3072     3072              
============================================
+ Hits          11241    11244       +3     
+ Misses         4538     4535       -3     
  Partials       1556     1556              
Impacted Files Coverage Δ
...ic/auth/http/jwt/AbstractHTTPJwtAuthenticator.java 50.00% <ø> (ø)
...mazon/dlic/auth/http/jwt/HTTPJwtAuthenticator.java 82.07% <ø> (ø)
...t/keybyoidc/AuthenticatorUnavailableException.java 0.00% <ø> (ø)
...th/http/jwt/keybyoidc/BadCredentialsException.java 40.00% <ø> (ø)
...byoidc/HTTPJwtKeyByOpenIdConnectAuthenticator.java 94.11% <ø> (ø)
...azon/dlic/auth/http/jwt/keybyoidc/JwtVerifier.java 85.71% <ø> (ø)
.../dlic/auth/http/jwt/keybyoidc/KeySetRetriever.java 76.82% <ø> (ø)
.../auth/http/jwt/keybyoidc/SelfRefreshingKeySet.java 59.85% <ø> (ø)
...ttp/jwt/oidc/json/OpenIdProviderConfiguration.java 100.00% <ø> (ø)
...ic/auth/http/kerberos/HTTPSpnegoAuthenticator.java 14.21% <ø> (ø)
... and 202 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b118b...e50cade. Read the comment docs.

hsiang9431-amzn
hsiang9431-amzn previously approved these changes Nov 9, 2021
Signed-off-by: Dave Lago <davelago@amazon.com>
@davidlago davidlago merged commit 565f47e into opensearch-project:main Nov 9, 2021
@davidlago davidlago deleted the copyright-notices branch November 9, 2021 18:30
davidlago pushed a commit to davidlago/security that referenced this pull request Nov 9, 2021
Signed-off-by: Dave Lago <davelago@amazon.com>
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Signed-off-by: Dave Lago <davelago@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants